Added non-exhaustive enums to the CLI #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy errors look unrelated to my change but feel free to correct me |
rdelfin
commented
Jun 10, 2024
bindgen/lib.rs
Outdated
| name_file.ends_with(".hxx") || | ||
| name_file.ends_with(".hh") || | ||
| name_file.ends_with(".h++") | ||
| name_file.ends_with(".hpp") |
There was a problem hiding this comment.
Oh... This must be my rustfmt settings. Strange, I'd have expected my IDE to grab them from the rustfmt.toml at the top
There was a problem hiding this comment.
you need nightly rust to format bindgen's code
pvdrz
requested changes
Jun 11, 2024
kulp
reviewed
Jun 21, 2024
|
Sorry for the delay! Should be sorted now |
kulp
approved these changes
Jun 23, 2024
pvdrz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CLI allows for all other enum builder options except for non-exhaustive rustified enums. This PR fixes the omission.
Solves #2846