Integrate more idiomatic rust changes.

rust-lang · Apr 17, 2020 · 66b855c · 66b855c
1 parent 9c89cf0
commit 66b855c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/clippy_lints/src/precedence.rs b/clippy_lints/src/precedence.rs
@@ -104,14 +104,16 @@ impl EarlyLintPass for Precedence {
 
         if let ExprKind::Unary(UnOp::Neg, ref rhs) = expr.kind {
             if let ExprKind::MethodCall(ref path_segment, ref args) = rhs.kind {
+                let path_segment_str = path_segment.ident.name.as_str();
                 if let Some(slf) = args.first() {
                     if let ExprKind::Lit(ref lit) = slf.kind {
                         match lit.kind {
                             LitKind::Int(..) | LitKind::Float(..) => {
-                                for &odd_function in &ODD_FUNCTIONS_WHITELIST {
-                                    if odd_function == &*path_segment.ident.name.as_str() {
-                                        return;
-                                    }
+                                if ODD_FUNCTIONS_WHITELIST
+                                    .iter()
+                                    .any(|odd_function| **odd_function == *path_segment_str)
+                                {
+                                    return;
                                 }
                                 let mut applicability = Applicability::MachineApplicable;
                                 span_lint_and_sugg(