Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on let _ = x.lock(); #1574

Closed
mcarton opened this issue Feb 25, 2017 · 4 comments · Fixed by #5101
Closed

Warn on let _ = x.lock(); #1574

mcarton opened this issue Feb 25, 2017 · 4 comments · Fixed by #5101
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience. L-correctness Lint: Belongs in the correctness lint group T-middle Type: Probably requires verifiying types

Comments

@mcarton
Copy link
Member

mcarton commented Feb 25, 2017

See #40096.
@mcarton mcarton added L-correctness Lint: Belongs in the correctness lint group E-medium Call for participation: Medium difficulty level problem and requires some initial experience. A-lint Area: New lints T-middle Type: Probably requires verifiying types labels Feb 25, 2017
@ishitatsuyuki
Copy link
Contributor

ishitatsuyuki commented Mar 1, 2017 •
edited
Loading

Which #40096?

EDIT: rust-lang/rust#40096

@mcarton
Copy link
Member Author

mcarton commented Mar 1, 2017

Fortunately Clippy isn't at 40096 (yet 😄)!

@FaultyRAM
Copy link

Note that rustc has a lint unused-results that could conflict with this (as one way to resolve that lint is via a let _ binding).

@mcarton
Copy link
Member Author

mcarton commented Mar 3, 2017

@FaultyRAM the rustc lint does not lint on _name.

@F001 F001 mentioned this issue Jun 2, 2017
Closed
@basil-cow basil-cow mentioned this issue Jan 27, 2020
Merged
bors added a commit that referenced this issue Jan 30, 2020
@bors
Auto merge of #5101 - Areredify:let_underscore_lock, r=flip1995
c13268a 
add `let_underscore_lock` lint

closes #1574
changelog: add `let_underscore_lock` lint

I am not entirely sure about my docs/messages wording here, improvements are welcome
@bors bors closed this as completed in 668bc48 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience. L-correctness Lint: Belongs in the correctness lint group T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add let_underscore_lock lint basil-cow/rust-clippy
3 participants
@FaultyRAM @mcarton @ishitatsuyuki