Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unwrap_or_else false positive #1653

Closed
clarfonthey opened this issue Apr 1, 2017 · 0 comments · Fixed by #4429
Closed

unwrap_or_else false positive #1653

clarfonthey opened this issue Apr 1, 2017 · 0 comments · Fixed by #4429
Labels
C-bug Category: Clippy is not doing the correct thing E-medium Call for participation: Medium difficulty level problem and requires some initial experience. T-middle Type: Probably requires verifiying types

Comments

@clarfonthey
Copy link
Contributor

Code from toml-rs:

self.chars.clone().next().map(|i| i.0).unwrap_or(self.input.len())

Currently, it's suggesting to change this to unwrap_or_else when this is a simple value copy.
@clarfonthey clarfonthey mentioned this issue Apr 1, 2017
Merged
@oli-obk oli-obk added E-medium Call for participation: Medium difficulty level problem and requires some initial experience. C-bug Category: Clippy is not doing the correct thing T-middle Type: Probably requires verifiying types labels Apr 4, 2017
@jeremystucki jeremystucki mentioned this issue Aug 21, 2019
Merged
bors added a commit that referenced this issue May 25, 2020
@bors
Auto merge of #4429 - jeremystucki:or_fun_call, r=flip1995
f7c486c 
Update 'or_fun_call' to ignore calls to len

Resolves #1653

changelog: Update `or_fun_call`: Allow calls to `len` for Slice, Array & Vec.
@bors bors closed this as completed in dd06d29 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing E-medium Call for participation: Medium difficulty level problem and requires some initial experience. T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 'or_fun_call' to ignore calls to len jeremystucki/rust-clippy
2 participants
@oli-obk @clarfonthey