assertion_on_constants: False positive on debug_assert!(false, ...)

[dtolnay]

The following code currently triggers assertion_on_constants. I believe the specific pattern of debug_assert!(false, ...) should be ignored by this lint as there is no current better similarly concise way to express the behavior of panic-in-debug-mode-only.

fn main() {
    debug_assert!(false, "oh no");
}

Example occurrence in Chrome OS: platform/crosvm/gpu_display/src/lib.rs

Mentioning @Arkweid and @flip1995 who have worked on this lint.

---

clippy 0.0.212 (37f5c1e 2019-04-09)