Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import mitsuhiko's "Did you mean to use a state machine?" lint #4

Closed
pythonesque opened this issue Nov 19, 2014 · 6 comments · Fixed by #5125
Closed

Import mitsuhiko's "Did you mean to use a state machine?" lint #4

pythonesque opened this issue Nov 19, 2014 · 6 comments · Fixed by #5125
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience.

Comments

@pythonesque
Copy link
Contributor

Because man that thing is useful.
@Manishearth Manishearth mentioned this issue Nov 19, 2014
Open
@Manishearth Manishearth added E-medium Call for participation: Medium difficulty level problem and requires some initial experience. A-lint Area: New lints labels Aug 11, 2015
@clarfonthey clarfonthey mentioned this issue Jun 27, 2018
Open
@basil-cow
Copy link
Contributor

Can anyone provide context for this? I can't really find anything about that lint on the internet or in mitsuhiko's github

@mati865
Copy link
Contributor

mati865 commented Jan 29, 2020

https://github.com/mitsuhiko/rust-excessive-bools-lint
There are 2 lints inside: for excessive amount of booleans in structs and another for excessive amount of booleans in functions.

@basil-cow
Copy link
Contributor

Hmm, what about licensing? If we port it, do we have to include it's license?

@mati865
Copy link
Contributor

mati865 commented Jan 29, 2020

Hmm, what about licensing? If we port it, do we have to include it's license?

I'll defer that question to somebody who understands licensing.

@flip1995
Copy link
Member

We would have to rewrite it, without looking at the source code. Or we'd have to include the copyright notice of the project. Or mitsuhiko surrenders his copyright to us (the Clippy project) and we can reimplement it here in Clippy.

@basil-cow
Copy link
Contributor

Ok, I'll rewrite it without looking at the source code then

@basil-cow basil-cow mentioned this issue Feb 2, 2020
Merged
bors added a commit that referenced this issue Feb 5, 2020
@bors
Auto merge of #5125 - Areredify:too_many_bools, r=flip1995
4f988bd 
Port mitsuhiko's excessive bools lints

Closes #4 .
changelog: add `struct_excessive_bools` and `fn_params_excessive_bools` lints.
I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?
bors added a commit that referenced this issue Feb 6, 2020
@bors
Auto merge of #5125 - Areredify:too_many_bools, r=flip1995
5cb2e7f 
Port mitsuhiko's excessive bools lints

Closes #4 .
changelog: add `struct_excessive_bools` and `fn_params_excessive_bools` lints.
I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?
@bors bors closed this as completed in 75e983a Feb 6, 2020
@ebroto ebroto mentioned this issue Dec 15, 2020
Closed
camsteffen added a commit to camsteffen/rust-clippy that referenced this issue Jan 15, 2021
@camsteffen
# This is a combination of 6 commits.
aaf6bcf 
# This is the 1st commit message:

Split filter_map into manual_filter_map

# The commit message rust-lang#2 will be skipped:

# fixup! Split filter_map into manual_filter_map

# The commit message rust-lang#3 will be skipped:

# fixup! Split filter_map into manual_filter_map

# The commit message rust-lang#4 will be skipped:

# fixup! Split filter_map into manual_filter_map

# The commit message rust-lang#5 will be skipped:

# fixup! Split filter_map into manual_filter_map

# The commit message rust-lang#6 will be skipped:

# fixup! Split filter_map into manual_filter_map
@rick-kilgore rick-kilgore mentioned this issue Oct 30, 2022
Closed
surechen added a commit to surechen/rust-clippy that referenced this issue Jun 26, 2023
@surechen
Merge pull request rust-lang#4 from surechen/stable
cde5797 
add lint extern_without_repr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port mitsuhiko's excessive bools lints basil-cow/rust-clippy
5 participants
@pythonesque @mati865 @Manishearth @flip1995 @basil-cow