Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of lints does not work correctly with tool lints #4349

Closed
phansch opened this issue Aug 7, 2019 · 0 comments · Fixed by #4363
Closed

Deprecation of lints does not work correctly with tool lints #4349

phansch opened this issue Aug 7, 2019 · 0 comments · Fixed by #4363
Assignees
@phansch

Comments

@phansch
Copy link
Member

phansch commented Aug 7, 2019 •
edited
Loading

Observed this while working on #4348

  1. util/dev update_lints incorrectly removes the lint from src/lintlist/mod.rs. It should be marked as deprecated instead by using the deprecation field
  2. The lint deprecation does not take the clippy:: prefix into account
@phansch phansch self-assigned this Aug 7, 2019
This was referenced Aug 7, 2019
Merged
Merged
bors added a commit that referenced this issue Aug 14, 2019
@bors
Auto merge of #4363 - phansch:fix_lint_deprecation, r=flip1995
d37233c 
Update lint deprecation for tool lints

changelog: Allow tool lints (`clippy::*`) to be deprecated

Our lint deprecation previously didn't work for tool lints, because
`register_removed` was registering lints to be removed _without_ the
`clippy` prefix.

Fixes #4349
bors added a commit that referenced this issue Aug 14, 2019
@bors
Auto merge of #4363 - phansch:fix_lint_deprecation, r=flip1995
06430e7 
Update lint deprecation for tool lints

changelog: Allow tool lints (`clippy::*`) to be deprecated

Our lint deprecation previously didn't work for tool lints, because
`register_removed` was registering lints to be removed _without_ the
`clippy` prefix.

Fixes #4349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phansch phansch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update lint deprecation for tool lints phansch/rust-clippy
1 participant
@phansch