Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for derive_hash_xor_eq #4658

Closed
c410-f3r opened this issue Oct 11, 2019 · 0 comments · Fixed by #4766
Closed

False positive for derive_hash_xor_eq #4658

c410-f3r opened this issue Oct 11, 2019 · 0 comments · Fixed by #4766
Assignees
@phansch
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@c410-f3r
Copy link
Contributor

c410-f3r commented Oct 11, 2019 •
edited
Loading

derive_hash_xor_eq is triggered for custom traits that are named Hash.

Bad

#[derive(PartialEq)]
struct Foo;

trait Hash {}

impl Hash for Foo {}

Ok

#[derive(PartialEq)]
struct Foo;

trait Hash {}

impl self::Hash for Foo {}
@flip1995 flip1995 added the C-bug Category: Clippy is not doing the correct thing label Oct 14, 2019
@c410-f3r c410-f3r mentioned this issue Oct 14, 2019
Merged
@phansch phansch self-assigned this Oct 27, 2019
@phansch phansch mentioned this issue Nov 1, 2019
Merged
flip1995 added a commit to flip1995/rust-clippy that referenced this issue Nov 23, 2019
@flip1995
Rollup merge of rust-lang#4766 - phansch:fix_fp_in_derive_hash_xor_eq…
1c0ea87 
…, r=flip1995

Fix false positive in derive_hash_xor_eq

This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called `Hash`.

changelog: Fix false positive in `derive_hash_xor_eq`

Fixes rust-lang#4658
@bors bors closed this as completed in 93d84d7 Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phansch phansch

Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false positive in derive_hash_xor_eq phansch/rust-clippy
3 participants
@phansch @flip1995 @c410-f3r