Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Deprecate the REPLACE_CONSTS lints #5346

Closed
tesuji opened this issue Mar 21, 2020 · 1 comment · Fixed by #5380
Closed

Remove/Deprecate the REPLACE_CONSTS lints #5346

tesuji opened this issue Mar 21, 2020 · 1 comment · Fixed by #5380
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. good-first-issue These issues are a good way to get started with Clippy

Comments

@tesuji
Copy link
Contributor

tesuji commented Mar 21, 2020

The associated constants MIN/MAX on integer primitives is prefered and stabilized in Rust 1.43.
The module constants and ::{min,max}_value is soft-deprecated now and will be deprecated
in the next few releases.
As such, the REPLACE_CONSTS lints is deprecated. It could be removed and move to deprecated group.

cc #2380.
@flip1995 flip1995 added good-first-issue These issues are a good way to get started with Clippy E-help-wanted Call for participation: Help is requested to fix this issue. labels Mar 23, 2020
@flip1995
Copy link
Member

cc rust-lang/rust#68952

@tesuji tesuji mentioned this issue Mar 29, 2020
Merged
@bors bors closed this as completed in bfd1123 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate REPLACE_CONSTS lint tesuji/rust-clippy
2 participants
@flip1995 @tesuji