Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate REPLACE_CONSTS lint #5380

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Deprecate REPLACE_CONSTS lint #5380

merged 1 commit into from
Mar 30, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Mar 29, 2020 •
edited
Loading

Closes #5346
changelog: Deprecate replace_consts lint

@tesuji tesuji force-pushed the deprecate-REPLACE_CONSTS branch 4 times, most recently from 7e35a74 to d055b7d Compare March 29, 2020 05:58
@phansch
Copy link
Member

phansch commented Mar 30, 2020

This also closes #2380 then :)

phansch
phansch approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once #5390 is merged

@phansch
Copy link
Member

phansch commented Mar 30, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2020

📌 Commit d055b7d has been approved by phansch

@bors
Copy link
Contributor

bors commented Mar 30, 2020

⌛ Testing commit d055b7d with merge bfd1123...

@bors
Copy link
Contributor

bors commented Mar 30, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing bfd1123 to master...

@bors bors merged commit bfd1123 into rust-lang:master Mar 30, 2020
This was referenced Mar 30, 2020
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@tesuji tesuji deleted the deprecate-REPLACE_CONSTS branch March 30, 2020 12:43
@tesuji tesuji mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove/Deprecate the REPLACE_CONSTS lints
3 participants
@tesuji @phansch @bors