Add empty closure lint #5355
Add empty closure lint #5355
Conversation
|
☔ The latest upstream changes (presumably #5319) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #5380) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm not 100% convinced this is a necessary lint, do people ever write this? |
| /// ```rust | ||
| /// std::thread::spawn(|| {}); | ||
| /// ``` | ||
| pub EMPTY_CLOSURE, |
There was a problem hiding this comment.
the name should probably be spawn_empty_closure
| /// ``` | ||
| pub EMPTY_CLOSURE, | ||
| style, | ||
| "closure with empty body" |
There was a problem hiding this comment.
this should probably mention spawning
Me neither. I guess people don't (or they don't read their code after refactoring). Anyway if people are not convinced, we should just close the issue and this PR, it's totally fine. |
|
Sounds good. Let me know if you want to find something else to work on. We do have a couple issues like this where we filed stuff but weren't yet sure if we wanted them, sorry about that. |
This PR adds a lint that triggers spawned empty closures.
Fixes: #625
changelog: Add empty closure lint