Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin clippy version number to rustc version number? #6499

Closed
matthiaskrgr opened this issue Dec 23, 2020 · 2 comments · Fixed by #6526
Closed

pin clippy version number to rustc version number? #6499

matthiaskrgr opened this issue Dec 23, 2020 · 2 comments · Fixed by #6526
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started

Comments

@matthiaskrgr
Copy link
Member

Clippy has been on version 0.0.212 for quite some time now, and the version number has become quite irrelevant now that we always ship a -git version with nightly/beta/stable.

Should we pin the clippy to the respective rustc version like cargo does?
cargo 0.49.0 corresponds to rustc 1.49.0.
Equally, we could bump clippy to 0.1.49 for beta, and 0.1.50 for nightly.
@matthiaskrgr matthiaskrgr added the S-needs-discussion Status: Needs further discussion before merging or work can be started label Dec 23, 2020
@matthiaskrgr matthiaskrgr mentioned this issue Dec 23, 2020
Merged
@flip1995
Copy link
Member

I'm in favor of this

cc @rust-lang/clippy

@matthiaskrgr matthiaskrgr changed the title pin clippy version to rustc version? pin clippy version number to rustc version number? Dec 27, 2020
@Manishearth
Copy link
Member

+1

@matthiaskrgr matthiaskrgr mentioned this issue Dec 31, 2020
Merged
bors added a commit that referenced this issue Jan 1, 2021
@bors
Auto merge of #6526 - matthiaskrgr:version, r=Manishearth
60919e4 
make clippy version number correspond to rustc version number.

clippy 0.1.50 corresponds to rustc 1.50.x

This bumps the clippy version number from 0.0.212 to 0.1.50

Fixes #6499

Notes:
I used `cargo --version` because that way we can honour the version set in the `rust-toolchain` file.
When we bump the bootstrap compiler from 1.50 to 1.51, the version numbers will have to be changed to 1.51 or the test will fail.

---

changelog: make clippy version number correspond to rustc version number (rust 1.50.0 -> clippy 0.1.50)
@bors bors closed this as completed in 59397d6 Jan 1, 2021
@matthiaskrgr matthiaskrgr mentioned this issue Feb 5, 2021
Merged
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Feb 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make clippy version number correspond to rustc version number. matthiaskrgr/rust-clippy
3 participants
@matthiaskrgr @Manishearth @flip1995