Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent_struct_constructor is not useful enough #7248

Closed
Fishrock123 opened this issue May 19, 2021 · 2 comments
Closed

inconsistent_struct_constructor is not useful enough #7248

Fishrock123 opened this issue May 19, 2021 · 2 comments

Comments

@Fishrock123
Copy link
Contributor

Fishrock123 commented May 19, 2021

I do not want to ever have to think about this, because it does not matter and is not useful:

warning: struct constructor field order is inconsistent with struct definition field order
  --> src/main.rs:85:12
   |
85 |           Ok(Self {
   |  ____________^
86 | |             slack_authorization,
87 | |             redis_connection,
88 | |             expiry,
89 | |             slack_client,
90 | |         })
   | |_________^ help: try: `Self { slack_authorization, expiry, redis_connection, slack_client }`
   |
   = note: `#[warn(clippy::inconsistent_struct_constructor)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor

If this should be anywhere, it should be in rustfmt, so it can just get automatically applied and so that I don't waste my time on this.

At very most, this should be pedantic and not a warning by default.

@giraffate
Copy link
Contributor

inconsistent_struct_constructor was moved to pedantic by #7193.

@giraffate
Copy link
Contributor

I'm closing this because of #7248 (comment). If you have something on this, feel free to reopen this or make some comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants