Mark uninlined_format_args as pedantic #10265

Manishearth · 2023-01-31T03:34:25Z

We should restore this when rust-analyzer support gets better. Worth filing an issue to track.

changelog: Mark [uninlined_format_args] as pedantic

rustbot · 2023-01-31T03:34:30Z

(rustbot has picked a reviewer for you, use r? to override)

3434: Make clippy happy for Rust 1.67, allow `uninlined_format_args` r=Kerollmops a=dureuill # Pull Request This PR allows `uninlined_format_args` in CI for clippy. This is due to rust-lang/rust-clippy#10087, which in particular has correctness issues wrt edition 2018 crates, and is a big change altogether. rust-lang/rust-clippy#10265 is already open in order to change the category of this lint to "pedantic", meaning that if this latter PR merges, a future Rust release will accept our code unmodified wrt uninlined format arguments. As a result, this PR introduces the following changes: 1. Allow `uninlined_format_args` in the clippy command in CI. 2. Use rewind rather than seek(0) 3. Remove lifetimes that clippy deems needless. Co-authored-by: Louis Dureuil <louis@meilisearch.com>

llogiq · 2023-01-31T12:45:19Z

@bors r+

bors · 2023-01-31T12:45:21Z

📌 Commit b4e2b48 has been approved by llogiq

It is now in the queue for this repository.

bors · 2023-01-31T12:45:28Z

⌛ Testing commit b4e2b48 with merge f95333d...

Mark uninlined_format_args as pedantic Fixes #10087 We should restore this when rust-analyzer support gets better. Worth filing an issue to track.

bors · 2023-01-31T12:46:03Z

💔 Test failed - checks-action_test

nyurik · 2023-01-31T17:12:01Z

👎 I think we should reach a consensus on #10087 first - I honestly don't think we will gain anything if we release this change in 3 months per my comments in that issue

Manishearth · 2023-01-31T17:55:25Z

@nyurik I've already stated my disagreement on that point there, but yeah let's continue on Zulip

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/uninlined_format_args.20category.20take.202

Manishearth · 2023-01-31T17:57:30Z

Also in general when a lot of people are disabling a lint our attitude is to "shoot first ask questions later", I'd rather disable this and get it uplifted to at least beta.

Manishearth · 2023-01-31T19:21:37Z

@bors r=Alexendoo

bors · 2023-01-31T19:21:39Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors · 2023-01-31T19:21:40Z

📌 Commit b4e2b48 has been approved by Alexendoo

It is now in the queue for this repository.

bors · 2023-01-31T19:21:47Z

⌛ Testing commit b4e2b48 with merge 2880dcc...

bors · 2023-01-31T19:33:44Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 2880dcc to master...

Manishearth · 2023-02-07T00:27:52Z

Being uplifted in rust-lang/rust#107743 (comment)

workingjubilee · 2023-02-07T01:44:48Z

Thank you for fixing this!

…crum Release 1.67.1 - Revert back to LlvmArchiveBuilder on all platforms rust-lang#107360 - 🚨 fix unsoundness in bootstrap cache code rust-lang#105624 - Mark uninlined_format_args as pedantic rust-lang/rust-clippy#10265 - Revert "switch to the macos-12-xl builder" rust-lang#107574 r? `@Mark-Simulacrum`

This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265 https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265

Pkgsrc changes: * checksums only. Upstream changes: Version 1.67.1 (2023-02-09) =========================== - [Fix interoperability with thin archives.] (rust-lang/rust#107360) - [Fix an internal error in the compiler build process.] (rust-lang/rust#105624) - [Downgrade `clippy::uninlined_format_args` to pedantic.] (rust-lang/rust-clippy#10265)

https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265

Update changelog for beta-accepted labels Roses are red Violets are blue r? `@xFrednet` is better at this I can't rhyme. #10423 #10265 changelog: none

https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265

Mark uninlined_format_args as pedantic

b4e2b48

Manishearth requested a review from Alexendoo January 31, 2023 03:34

rustbot assigned llogiq Jan 31, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 31, 2023

Manishearth mentioned this pull request Jan 31, 2023

Temporarily downgrade uninlined_format_args (to pedantic or nursery) #10087

Closed

dureuill mentioned this pull request Jan 31, 2023

Make clippy happy for Rust 1.67, allow uninlined_format_args meilisearch/meilisearch#3434

Merged

bors added a commit that referenced this pull request Jan 31, 2023

Auto merge of #10265 - Manishearth:uninlined-fmt-pedantic, r=llogiq

f95333d

Mark uninlined_format_args as pedantic Fixes #10087 We should restore this when rust-analyzer support gets better. Worth filing an issue to track.

bors merged commit 2880dcc into rust-lang:master Jan 31, 2023

Manishearth deleted the uninlined-fmt-pedantic branch January 31, 2023 20:12

Manishearth added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 31, 2023

togami2864 mentioned this pull request Feb 3, 2023

chore: fix clippy error in ci apache/datafusion-sqlparser-rs#803

Merged

Niki4tap mentioned this pull request Feb 5, 2023

uninlined_format_args pushed for code that LSP doesn't properly parse #10297

Closed

cuviper mentioned this pull request Feb 6, 2023

Release 1.67.1 rust-lang/rust#107743

Merged

cuviper mentioned this pull request Feb 8, 2023

Backport reverts to fix thin archive reading for 1 68 beta rust-lang/rust#107609

Merged

citreae535 mentioned this pull request Feb 8, 2023

Breaking: change Service.delete to borrow rather than consume self mullvad/windows-service-rs#90

Merged

argerus mentioned this pull request Feb 11, 2023

CI fixes / improvements eclipse/kuksa.val#478

Merged

flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 2, 2023

ia0 mentioned this pull request Mar 6, 2023

Add verification library code. chipsalliance/caliptra-dpe#17

Merged

flip1995 mentioned this pull request Mar 10, 2023

Update changelog for beta-accepted labels #10475

Merged

flip1995 removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 10, 2023

bors added a commit that referenced this pull request Mar 10, 2023

Auto merge of #10475 - flip1995:beta-changelog, r=xFrednet

b0e2e7b

Update changelog for beta-accepted labels Roses are red Violets are blue r? `@xFrednet` is better at this I can't rhyme. #10423 #10265 changelog: none

Jake-Shadle mentioned this pull request Aug 23, 2023

Unconditionally query crates.io HTTP index for publish status crate-ci/cargo-release#693

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark uninlined_format_args as pedantic #10265

Mark uninlined_format_args as pedantic #10265

Manishearth commented Jan 31, 2023 •

edited

Loading

rustbot commented Jan 31, 2023

llogiq commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

nyurik commented Jan 31, 2023 •

edited

Loading

Manishearth commented Jan 31, 2023

Manishearth commented Jan 31, 2023

Manishearth commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

Manishearth commented Feb 7, 2023

workingjubilee commented Feb 7, 2023

Mark uninlined_format_args as pedantic #10265

Mark uninlined_format_args as pedantic #10265

Conversation

Manishearth commented Jan 31, 2023 • edited Loading

rustbot commented Jan 31, 2023

llogiq commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

nyurik commented Jan 31, 2023 • edited Loading

Manishearth commented Jan 31, 2023

Manishearth commented Jan 31, 2023

Manishearth commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Jan 31, 2023

Manishearth commented Feb 7, 2023

workingjubilee commented Feb 7, 2023

Manishearth commented Jan 31, 2023 •

edited

Loading

nyurik commented Jan 31, 2023 •

edited

Loading