Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct towards late passes in cargo dev new_lint #10907

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

Alexendoo
Copy link
Member

changelog: none

This would be the tooling part of #9311

  • --pass late is now the default
  • It prints a message recommending the use of a late pass if you choose --pass early

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 8, 2023
@flip1995
Copy link
Member

flip1995 commented Jun 8, 2023

  • It prints a message recommending the use of a late pass if you choose --pass early

I wouldn't add this. If someone passes --pass early they probably have a reason to do so already.

@Alexendoo Alexendoo force-pushed the dev-new-lint-late-passes branch from a64ce9b to 9b7cbb8 Compare June 8, 2023 14:10
@Alexendoo
Copy link
Member Author

For experienced contributors that's true, though it can serve as a nice poke for if it really should be an early lint, a few times I have started out writing an early lint and had to switch to late anyway

It's mostly aimed at newer contributors though, much of the documentation directs people towards --pass early which #9426 should remedy but that looks like it's a fair way away as it's a substantial change to review

In the meanwhile we relatively frequently get PRs such as #10885 where we have to ask people to redo their work in a late pass which isn't a great experience

clippy_dev/src/new_lint.rs Outdated Show resolved Hide resolved
@Alexendoo Alexendoo force-pushed the dev-new-lint-late-passes branch from 9b7cbb8 to 46808be Compare June 8, 2023 15:56
@Jarcho
Copy link
Contributor

Jarcho commented Jun 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2023

📌 Commit 46808be has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 10, 2023

⌛ Testing commit 46808be with merge ff3b49c...

@bors
Copy link
Contributor

bors commented Jun 10, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing ff3b49c to master...

@bors bors merged commit ff3b49c into rust-lang:master Jun 10, 2023
@Alexendoo Alexendoo deleted the dev-new-lint-late-passes branch June 10, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants