-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct towards late passes in cargo dev new_lint
#10907
Conversation
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
I wouldn't add this. If someone passes |
a64ce9b
to
9b7cbb8
Compare
For experienced contributors that's true, though it can serve as a nice poke for if it really should be an early lint, a few times I have started out writing an early lint and had to switch to late anyway It's mostly aimed at newer contributors though, much of the documentation directs people towards In the meanwhile we relatively frequently get PRs such as #10885 where we have to ask people to redo their work in a late pass which isn't a great experience |
9b7cbb8
to
46808be
Compare
@bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: none
This would be the tooling part of #9311
--pass late
is now the default--pass early