Add needless_if lint
#10921
Merged
Add needless_if lint
#10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Centri3
force-pushed
the
needless_if
branch
2 times, most recently
from
1d90048
to
0fc3b31
Compare
|
Yep, Will review it! |
add description
blyxyas
requested changes
Jun 11, 2023
don't lint on `if let`
|
Some cases to check: if true {
#[cfg(any())]
foo;
}macro_rules! m {
($($t:tt)*) => {
if true {
$($t)*
}
}
}
m!(); |
Manishearth
reviewed
Jun 12, 2023
|
@bors r=blyxyas,Manishearth looks great, you can ignore the comment i left or make a followup PR if you agree with me |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jun 12, 2023
Sorry I didn't get to this 😅 I'll do this as a followup, though I'm pretty sure it'll lint on both currently. |
|
Opened #10935 for that + a few other cases I thought of/ran into |
bors
added a commit
that referenced
this pull request
Jun 13, 2023
Don't lint non-statement/faux empty `needless_if`s Also has a basic fall-back for `if` statements that have attributes applied to them and incorporates #10921 (review) while I was there r? `@Manishearth` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first off: Sorry about the large diff. Seems a ton of tests do this (understandably so).
this is basically everything I wanted in #10868, while it doesn't lint all unnecessary empty blocks, it lints needless if statements; which are basically the crux of the issue (for me) anyway. I've committed code that includes this far too many times 😅 hopefully clippy can help me out soon
closes #10868
changelog: New lint [
needless_if]