Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle single chars with to_string() for single_char_add_str #12915

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

belyakov-am
Copy link
Contributor

Add support for single chars / literals with to_string() call for push_str() and insert_str().

changelog: [single_char_add_str]: handle single chars with to_string() call

Closes #12775

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 9, 2024
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Clippy. A fantastic first contribution. Everything looks good to me.

@xFrednet
Copy link
Member

Bors our merge bot,
as something to say,
to merge this PR,
it will test it hurray.

This is just a fun way, to add this PR into the merge queue :P

@bors
Copy link
Contributor

bors commented Jun 11, 2024

📌 Commit f7723ca has been approved by xFrednet

It is now in the queue for this repository.

@belyakov-am
Copy link
Contributor Author

Thank you!
I'm glad to contribute to Clippy. Looking forward to more contributions in the future

@bors
Copy link
Contributor

bors commented Jun 11, 2024

⌛ Testing commit f7723ca with merge 87c895a...

@bors
Copy link
Contributor

bors commented Jun 11, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 87c895a to master...

@bors bors merged commit 87c895a into rust-lang:master Jun 11, 2024
5 checks passed
@belyakov-am belyakov-am deleted the lint/single_char_add_str branch June 11, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lint: adding a char to a String through to_string()
4 participants