-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle single chars with to_string()
for single_char_add_str
#12915
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Clippy. A fantastic first contribution. Everything looks good to me.
Bors our merge bot, This is just a fun way, to add this PR into the merge queue :P |
Thank you! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Add support for single chars / literals with
to_string()
call forpush_str()
andinsert_str()
.changelog: [
single_char_add_str
]: handle single chars withto_string()
callCloses #12775