Misc refactorings part 2 #13065
Merged
Misc refactorings part 2 #13065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merge control flow before emission * Check the AST before the macro check
* Merge code paths. * Check HIR tree before checking for macros.
* Check HIR tree before checking for macros. * Check item count before checking for bools.
* Inline `is_empty_exported_or_macro`. * Check if there are any generic parameters before walking the signature.
* Check HIR tree first. * Merge lint calls.
rustbot
added
the
S-waiting-on-review
|
r? @xFrednet |
xFrednet
approved these changes
Jul 22, 2024
|
LGTM, nice refactorings. Thank you! Poems are hard, |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of theses are a bit more involved. No behaviour changes included in this set.
changelog: none