Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed incorrect comment form suggestion for too_long_first_doc_paragraph lint #13377

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: Fixed incorrect comment form suggestion for too_long_first_doc_paragraph lint #13377

merged 1 commit into from
Sep 13, 2024

Conversation

vHugoObject
Copy link
Contributor

fixes #13309
changelog: none

Comment form is now a variable and a new test for too_long_first_doc_paragraph was added.

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 10, 2024
dswij
dswij reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good, just a minor comment.

Can you squash some commits?

tests/ui/too_long_first_doc_paragraph_module_level.rs Outdated Show resolved Hide resolved
@vHugoObject
fix: Fixed incorrect comment form suggestion
d66e9ad 
chore: Ran cargo dev fmt

chore: Fixed spacing

fix: Fixed spacing for comment suggestion

fix: Added new module level test to too_long_first_doc_paragraph

chore: Ran cargo uibless
@vHugoObject
Copy link
Contributor Author

Thanks for this! Looks good, just a minor comment.

Can you squash some commits?

yes

dswij
dswij reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for addressing the comment

@dswij
Copy link
Member

dswij commented Sep 13, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 13, 2024

📌 Commit d66e9ad has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 13, 2024

⌛ Testing commit d66e9ad with merge 2b7d80b...

@bors
Copy link
Contributor

bors commented Sep 13, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 2b7d80b to master...

@bors bors merged commit 2b7d80b into rust-lang:master Sep 13, 2024
8 checks passed
@y21 y21 mentioned this pull request Sep 24, 2024
Closed
@SpriteOvO SpriteOvO mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij left review comments

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

too_long_first_doc_paragraph incorrect suggestion for module-level doc
4 participants
@vHugoObject @rustbot @dswij @bors