-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build quine-mc_cluskey with opt-level=3
in dev builds
#13408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, good catch. This makes sense. I can't test this locally right now, so I leave the final approval to @dswij
(I just added a comment for context since it might not be obvious why this is done) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Tested locally on my machine and it seems to hit that sweet 30+s mark cut 😄
@bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
@y21 I had to revert this during the sync rust-lang/rust#130778 in commit rust-lang/rust@f38b569 as this caused warnings when building in the Rust repo:
Those would be annoying to the Rust devs. I didn't know how best to fix this otherwise and don't want to delay the sync further. |
Ah, that's unfortunate... I'll try to get this to work without affecting rust-lang/rust, but yeah, reverting it just to unblock the sync for now sounds fine |
While doing some profiling I noticed that debug clippy running on the
clippy_lints
crate spends 35s out of 160s in one specific code path ofnonminimal_bool
, which seemed a bit excessive.I've found that just enabling optimizations for quine-mc_cluskey (used by nonminimal_bool) cuts down the part that took 35s to 3s
While this doesn't really change anything for users, this helps dogfood a bit as it cuts off about half a minute of runtime (in some of my tests, at least).
Something similar was attempted in #10576, however that involved compiling everything in release mode including clippy itself, whereas this only affects a single dependency that's compiled in parallel with something that takes longer so this should hopefully not have a negative impact in any case (and changing clippy doesn't require recompiling that dependency)
changelog: none