Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15) #1833

Merged
merged 2 commits into from
Jun 16, 2017
Merged

rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15) #1833

merged 2 commits into from
Jun 16, 2017

Conversation

messense
Copy link
Contributor

@@ -1,59 +0,0 @@
error: I see you're using a LinkedList! Perhaps you meant some other data structure?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, This don't seem right.

@@ -1,11 +1,3 @@
error: Range::step_by(0) produces an infinite iterator. Consider using `std::iter::repeat()` instead
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this got removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@messense step_by is no longer a Range method due to rust-lang/rust#42310. These lines in clippy_lints/src/ranges.rs should be modified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess it's better to rewrite it to lint on Iterator::step_by(0)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, Iterator::step_by has assert!(step != 0);, it will panic if the given step is 0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #95 no longer applies I'd vote for accepting the changeset and deprecating the lint later.

cc @llogiq

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@oli-obk oli-obk merged commit 50a1fd1 into rust-lang:master Jun 16, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Jun 16, 2017

published as 0.0.140

@messense messense deleted the feature/fix-nightly-06-16 branch June 17, 2017 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants