-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15) #1833
Conversation
clippy_tests/examples/dlist.stderr
Outdated
@@ -1,59 +0,0 @@ | |||
error: I see you're using a LinkedList! Perhaps you meant some other data structure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, This don't seem right.
@@ -1,11 +1,3 @@ | |||
error: Range::step_by(0) produces an infinite iterator. Consider using `std::iter::repeat()` instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this got removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@messense step_by
is no longer a Range method due to rust-lang/rust#42310. These lines in clippy_lints/src/ranges.rs
should be modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I guess it's better to rewrite it to lint on Iterator::step_by(0)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, Iterator::step_by
has assert!(step != 0);
, it will panic if the given step is 0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
published as 0.0.140 |
Caused by rust-lang/rust#42648