Revert "Fix E0502 warnings" #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Curious. Let's wait for the issue to be closed, and then merge this PR |
| @@ -448,8 +448,7 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> { | |||
| CaptureClause::CaptureByValue => 0, | |||
| CaptureClause::CaptureByRef => 1, | |||
| }.hash(&mut self.s); | |||
| let value = &self.cx.tcx.hir.body(eid).value; | |||
| self.hash_expr(value); | |||
There was a problem hiding this comment.
Hmm, I wonder if this is due to my changes in rust-lang/rust#53177 -- specifically the redundant borrow optimization. It doesn't seem wrong to me that these fixes are working but it is making me nervous. I wonder what changed here.
There was a problem hiding this comment.
people who are curious to learn more here may want to read my notes starting here: rust-lang/rust#52934 (comment)
flip1995
added
the
S-blocked
phansch
removed
the
S-blocked
|
rust-lang/rust#53948 has been merged, so I'm going to retrigger CI to see if we can safely revert this 👍 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 98dbce4.
The compiler no longer emits the warnings in #2982 with the original
code.