Make clippy_lints::{utils,consts} modules private, remove unused items. #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
commented
Aug 29, 2018
| @@ -0,0 +1,114 @@ | |||
| /// Return the index of the character after the first camel-case component of | |||
| /// `s`. | |||
| pub fn camel_case_until(s: &str) -> usize { | |||
There was a problem hiding this comment.
moved from clippy_lints/src/utils/mod.rs
oli-obk
suggested changes
Aug 29, 2018
clippy_lints/src/utils/sugg.rs
Outdated
| @@ -175,15 +175,6 @@ impl<'a> Sugg<'a> { | |||
| make_unop("&mut *", self) | |||
| } | |||
|
|
|||
| /// Convenience method to create the `<lhs>..<rhs>` or `<lhs>...<rhs>` | |||
There was a problem hiding this comment.
Please leave that one in (maybe just keep exporting the Sugg type). I think we'll want to upstream it to rustc at some point and have it support a lot of expressions. Also there's an open issue about using this function on a bad suggestion currently produced due to not using this function
|
comment has been addressed |
oli-obk
approved these changes
Aug 29, 2018
|
Anyone able to merge this who has permissions? |
|
Yeah, @oli-obk 😄 |
flip1995
reviewed
Sep 1, 2018
| #[macro_use] | ||
| pub mod utils; | ||
| mod utils; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Does RLS use any utils anywhere else?
|
Could you leave the requested comment in #3230 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.