-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for bad get unwrap suggestion #3178
Conversation
Access denied in dogfood test? |
That is unrelated: #3118 But it seems this PR produces ICEs in |
ff46c48
to
39cd2b2
Compare
I should have that issue fixed ... thanks for pointing that out Edit: I rebased and am now failing tests on different part of code? |
Master fails with the same error(outdated test):
|
Fixed in #3194. You can rebase again and then travis should pass. |
thanks! |
Could you leave the requested comment in #3230 ? |
Fix for issue outlined in #3006, get() returns either a reference or a slice and therefore "&" should only be added when get is returning a reference ( ie .get(1) instead of .get(0..1) )