RIIR update lints: Generate deprecated lints #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes.
phansch
commented
Oct 31, 2018
clippy_dev/src/lib.rs
Outdated
| r#" store.register_removed( | ||
| "{}", | ||
| "{}", | ||
| );"#, |
There was a problem hiding this comment.
Can we make a bet that this will trigger clippys filter_maplint?
(only nagging because I found another sample of this when starting to clean up pedantic warnings and was not sure if this was a FP or TP :p )
There was a problem hiding this comment.
oh, yeah. I forgot to run the dogfood tests locally :(
Will fix it later today.
There was a problem hiding this comment.
It's not gonna catch that because pedantic lints are not (yet..) enabled I think.
There was a problem hiding this comment.
pedantic lints are not (yet..) enabled I think.
Yep #3172 (comment)
phansch
added
the
S-waiting-on-author
|
I changed the |
phansch
added
S-waiting-on-review
|
LGTM! bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2018
3388: RIIR update lints: Generate deprecated lints r=flip1995 a=phansch The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes. cc #2882 Co-authored-by: Philipp Hansch <dev@phansch.net>
|
Oh forgot that macos nightly is missing. r=me when available again |
flip1995
approved these changes
Nov 1, 2018
Build failed |
|
bors r=flip1995 |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2018
3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 3387: Replace big if/else expression with match r=flip1995 a=mikerite 3388: RIIR update lints: Generate deprecated lints r=phansch a=phansch The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes. cc #2882 Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com> Co-authored-by: Michael Wright <mikerite@lavabit.com> Co-authored-by: Philipp Hansch <dev@phansch.net>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2018
3388: RIIR update lints: Generate deprecated lints r=phansch a=phansch The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes. cc #2882 Co-authored-by: Philipp Hansch <dev@phansch.net>
phansch
removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update script now also generates the 'register_removed' section in
clippy_lints/src/lib.rs.Also, instead of using
let mut store ..., I added a new identifierline so that the replacement will continue to work in case
let mut store ...ever changes.cc #2882