Remove negative integer literal checks. #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
added
the
S-waiting-on-author
oli-obk
suggested changes
Jan 21, 2019
clippy_lints/src/arithmetic.rs
Outdated
| @@ -92,11 +92,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Arithmetic { | |||
| } | |||
| }, | |||
| hir::ExprKind::Unary(hir::UnOp::UnNeg, arg) => { | |||
| let ty = cx.tables.expr_ty(arg); | |||
| if ty.is_integral() { | |||
There was a problem hiding this comment.
Instead of removing the lint entirely, I think we should only skip reporting it if arg is a constant. You can use clippy's const folder to check if it's a constant. If it is, don't report the lint. That should cause -1 and -(-1) to stop linting, but -i and -(-i) not.
There was a problem hiding this comment.
Not sure if that is what you meant, but it seems to work.
There was a problem hiding this comment.
jup, exactly what I had in mind
oli-obk
approved these changes
Jan 21, 2019
|
@bors r+ |
|
📌 Commit 87d24e1 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 21, 2019
Remove negative integer literal checks. Fixes #3678.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3678.