Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage due to rust-lang/rust#58079 #3736

Merged
merged 1 commit into from Feb 3, 2019
Merged

Fix breakage due to rust-lang/rust#58079 #3736

merged 1 commit into from Feb 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 3, 2019

The rustc change added HirId to a few nodes. As I understand it, the plan is
to remove the NodeId from these nodes eventually. Where the NodeId was
not being matched, I used .. to try and avoid further breakage. Where it
was, I used _ to make the fix easier when NodeId is removed.

The rustc change added HirId to a few nodes. As I understand it, the plan is
to remove the NodeId from these nodes eventually. Where the NodeId was
not being matched, I used `..` to try and avoid further breakage. Where it
was, I used `_` to make the fix easier when NodeId is removed.
@phansch
Copy link
Member

phansch commented Feb 3, 2019

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2019

📌 Commit c02367c has been approved by phansch

@bors
Copy link
Contributor

bors commented Feb 3, 2019

⌛ Testing commit c02367c with merge 3bda548...

bors added a commit that referenced this pull request Feb 3, 2019
Fix breakage due to rust-lang/rust#58079

The rustc change added HirId to a few nodes. As I understand it, the plan is
to remove the NodeId from these nodes eventually. Where the NodeId was
not being matched, I used `..` to try and avoid further breakage. Where it
was, I used `_` to make the fix easier when NodeId is removed.
@bors
Copy link
Contributor

bors commented Feb 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 3bda548 to master...

@bors bors merged commit c02367c into rust-lang:master Feb 3, 2019
@ghost ghost deleted the fix-build-20190203 branch May 11, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants