Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updated type dependent def ID getter #3937

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

stepnivlk
Copy link

This PR changes all the calls to type_dependent_defs (with panics via []) to new method type_dependent_def_id with more explicit unwrap panic.

Rust PR: rust-lang/rust#59216
Issue author: @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Apr 10, 2019

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 10, 2019

📌 Commit 603996c has been approved by oli-obk

bors added a commit that referenced this pull request Apr 10, 2019
Support updated type dependent def ID getter

This PR changes all the calls to `type_dependent_defs` (with panics via `[]`) to new method `type_dependent_def_id` with more explicit `unwrap` panic.

Rust PR: rust-lang/rust#59216
Issue author: @oli-obk
@bors
Copy link
Contributor

bors commented Apr 10, 2019

⌛ Testing commit 603996c with merge f23216d...

@bors
Copy link
Contributor

bors commented Apr 10, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented Apr 10, 2019

@bors retry (master toolchain install failed)

bors added a commit that referenced this pull request Apr 10, 2019
Support updated type dependent def ID getter

This PR changes all the calls to `type_dependent_defs` (with panics via `[]`) to new method `type_dependent_def_id` with more explicit `unwrap` panic.

Rust PR: rust-lang/rust#59216
Issue author: @oli-obk
@bors
Copy link
Contributor

bors commented Apr 10, 2019

⌛ Testing commit 603996c with merge 3efc3e2...

@bors
Copy link
Contributor

bors commented Apr 10, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 3efc3e2 to master...

@bors bors merged commit 603996c into rust-lang:master Apr 10, 2019
@stepnivlk stepnivlk deleted the type_dependent_defs-wrappers branch April 10, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants