make needless_return work with void functions #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing & Re-opening to trigger a new build |
flip1995
reviewed
Jun 21, 2019
flip1995
reviewed
Jun 21, 2019
flip1995
reviewed
Jun 21, 2019
flip1995
added
the
S-waiting-on-review
|
Thanks! @bors r+ |
|
📌 Commit 316a9f2 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 22, 2019
…r=flip1995 make needless_return work with void functions fixes #4181. changelog: make needless_return work with void functions. I don't think the failure is related to my changes, but I'm not sure 🤔
|
💔 Test failed - checks-travis |
|
waiting for #4227 |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jun 22, 2019
…r=flip1995 make needless_return work with void functions fixes #4181. changelog: make needless_return work with void functions. I don't think the failure is related to my changes, but I'm not sure 🤔
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4181.
changelog: make needless_return work with void functions.
I don't think the failure is related to my changes, but I'm not sure 🤔