Replace unsugar_if function with is_if function
#4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
We should just remove it -- it was useful when if and if let used different ASTs, but it's not anymore, you can just match on the if. |
flip1995
commented
Jun 24, 2019
| if let Some((then, &Some(ref else_))) = unsugar_if(expr); | ||
| if is_block(else_) || unsugar_if(else_).is_some(); | ||
| if let ExprKind::If(_, then, Some(else_)) = &expr.node; | ||
| if is_block(else_) || is_if(else_); |
There was a problem hiding this comment.
There are multiple occurences of this function in a || or && expression. Removing this function would make the code way more complicated IMO
|
@bors r+ fair enough! |
|
📌 Commit 662037b has been approved by |
bors
added a commit
that referenced
this pull request
Jun 24, 2019
Replace `unsugar_if` function with `is_if` function cc #4123 (comment) changelog: none r? @Manishearth
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #4123 (comment)
changelog: none
r? @Manishearth