Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix Travis Windows build flakiness #4320

Closed
wants to merge 1 commit into from
Closed

Try to fix Travis Windows build flakiness #4320

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2019

changelog: none

@flip1995
Copy link
Member

flip1995 commented Aug 1, 2019

https://travis-ci.com/rust-lang/rust-clippy/jobs/221479483#L1727-L1730

./target/debug/clippy-driver --print sysroot
sysroot=/home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu
rustc --print sysroot
test /home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu = /home/travis/.rustup/toolchains/master

Because clippy is now compiled with the nightly toolchain, it's sysroot is also the nightly toolchain. And this results in the failing sysroot checks.

I'd suggest to just allow_failures on windows builds on travis again.

@phansch phansch mentioned this pull request Aug 1, 2019
Merged
@ghost
Copy link
Author

ghost commented Aug 2, 2019

Then let's use cargo master instead of building with cargo nightly via rustup fallback. I've opened #4324 to try this.

@ghost ghost closed this Aug 3, 2019
@ghost ghost deleted the fix-build-20190801 branch August 3, 2019 05:19
@flip1995 flip1995 mentioned this pull request Sep 26, 2019
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flip1995