Fix wrong_self_convention issue
#4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2019 05:58
`impl_item` is proper snake case and used everywhere else.
Use actual types instead of hir types.
Resolves #4293
phansch
added
the
S-waiting-on-review
|
Thanks! @bors r+ |
|
📌 Commit 77278cc has been approved by |
bors
added a commit
that referenced
this pull request
Aug 14, 2019
Fix `wrong_self_convention` issue Resolves #4293 changelog: Fix `wrong_self_convention` issue
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4293
changelog: Fix
wrong_self_conventionissue