Fix assertions on const lint #4406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ thanks! |
|
📌 Commit 533bdfb has been approved by |
bors
added a commit
that referenced
this pull request
Aug 18, 2019
Fix assertions on const lint Replaces #4402 changelog: none
|
💔 Test failed - status-appveyor |
|
Failed because of rust-lang/rust#61708 |
Yes, looks like we have to add support for Or patterns now. It shouldn't be too difficult to get Clippy to pass tests again, because we don't have any Or pattern tests yet. |
ghost
mentioned this pull request
bors
added a commit
that referenced
this pull request
Aug 18, 2019
Fix breakage due to rust-lang/rust#61708 Includes commits from #4406 changelog: none
|
Thanks, closing in favor of #4407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4402
changelog: none