-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redundant_pattern
false positive
#4489
Merged
bors
merged 3 commits into
rust-lang:master
from
JohnTitor:fix-redundant-pattern-false-positive
Sep 5, 2019
Merged
Fix redundant_pattern
false positive
#4489
bors
merged 3 commits into
rust-lang:master
from
JohnTitor:fix-redundant-pattern-false-positive
Sep 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Sep 4, 2019
flip1995
reviewed
Sep 4, 2019
JohnTitor
force-pushed
the
fix-redundant-pattern-false-positive
branch
from
September 4, 2019 15:50
3ddf960
to
8be37fd
Compare
flip1995
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also want to run rustfix on all of the auto applicable lints
Thanks! @bors r+ |
📌 Commit 0b3f452 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 5, 2019
… r=flip1995 Fix `redundant_pattern` false positive Fix #4428 changelog: Fix `redundant_pattern` false positive
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4428
changelog: Fix
redundant_pattern
false positive