Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy::cargo_common_metadata: check for license-file #4518

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

imp
Copy link
Contributor

@imp imp commented Sep 7, 2019

When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes #4517

changelog: clippy::cargo_common_metadata now checks for license-file when license is missing

@imp imp changed the title clippy::common-cargo-metadata: check for license-file clippy::cargo_common_metadata: check for license-file Sep 7, 2019
@imp imp force-pushed the 4517_license-file branch 2 times, most recently from 0b389d1 to ccef83c Compare September 7, 2019 09:43
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 7, 2019
@imp
Copy link
Contributor Author

imp commented Sep 8, 2019

Looks like build fails victim to rust-lang/rust#64231

@imp imp force-pushed the 4517_license-file branch 2 times, most recently from eb6200c to bcf9e12 Compare September 21, 2019 11:28
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
@phansch
Copy link
Member

phansch commented Sep 22, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Sep 22, 2019

📌 Commit 4c881d1 has been approved by phansch

@bors
Copy link
Contributor

bors commented Sep 22, 2019

⌛ Testing commit 4c881d1 with merge 157edad...

bors added a commit that referenced this pull request Sep 22, 2019
clippy::cargo_common_metadata: check for license-file

When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes #4517

changelog: clippy::cargo_common_metadata now checks for license-file when license is missing
@bors
Copy link
Contributor

bors commented Sep 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 157edad to master...

@bors bors merged commit 4c881d1 into rust-lang:master Sep 22, 2019
@imp imp deleted the 4517_license-file branch September 22, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::cargo_common_metadata ignores license-file metadata
4 participants