Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nonminimal-bool false positive #4568

Merged
merged 2 commits into from Sep 26, 2019
Merged

Fix nonminimal-bool false positive #4568

merged 2 commits into from Sep 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2019

Closes #4548
Closes #3847

changelog: Fix nonminimal-bool false positive

flip1995
flip1995 reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one thing left from the old code, that can be improved. r=me once this is fixed

clippy_lints/src/booleans.rs Outdated Show resolved Hide resolved
Refactor booleans
89cdd26 
Inline `snip (..)` function
@phansch
Copy link
Member

phansch commented Sep 25, 2019

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Sep 25, 2019

📌 Commit 89cdd26 has been approved by flip1995

bors added a commit that referenced this pull request Sep 25, 2019
@bors
Auto merge of #4568 - mikerite:fix-4548, r=flip1995
b993b80 
Fix `nonminimal-bool` false positive

Closes #4548
Closes #3847

changelog: Fix `nonminimal-bool` false positive
@bors
Copy link
Contributor

bors commented Sep 25, 2019

⌛ Testing commit 89cdd26 with merge b993b80...

@phansch
Copy link
Member

phansch commented Sep 25, 2019

Toolstate just changed to test-fail, so this will probably not pass CI now.

@bors
Copy link
Contributor

bors commented Sep 25, 2019

💔 Test failed - status-appveyor

@matthiaskrgr
Copy link
Member

@bors retry

bors added a commit that referenced this pull request Sep 26, 2019
@bors
Auto merge of #4568 - mikerite:fix-4548, r=flip1995
adc1df1 
Fix `nonminimal-bool` false positive

Closes #4548
Closes #3847

changelog: Fix `nonminimal-bool` false positive
@bors
Copy link
Contributor

bors commented Sep 26, 2019

⌛ Testing commit 89cdd26 with merge adc1df1...

@bors
Copy link
Contributor

bors commented Sep 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing adc1df1 to master...

@bors bors merged commit 89cdd26 into rust-lang:master Sep 26, 2019
@flip1995 flip1995 mentioned this pull request Dec 22, 2019
Closed
@ghost ghost deleted the fix-4548 branch December 26, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@phansch @bors @matthiaskrgr @flip1995