Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow casts from the result of abs to unsigned #4614

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Allow casts from the result of abs to unsigned #4614

merged 1 commit into from
Oct 4, 2019

Conversation

HMPerson1
Copy link
Contributor

changelog: Allow casts from the result of abs to unsigned in cast_sign_loss

Fixes #4605

@flip1995
Copy link
Member

flip1995 commented Oct 3, 2019

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 3, 2019

📌 Commit 0e1dd65 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Oct 3, 2019

⌛ Testing commit 0e1dd65 with merge bc60c1f...

bors added a commit that referenced this pull request Oct 3, 2019
@bors
Auto merge of #4614 - HMPerson1:abs_cast_unsigned, r=flip1995
bc60c1f 
Allow casts from the result of `abs` to unsigned

changelog: Allow casts from the result of `abs` to unsigned in `cast_sign_loss`

Fixes #4605
@bors
Copy link
Contributor

bors commented Oct 3, 2019

💔 Test failed - status-appveyor

@HMPerson1
Copy link
Contributor Author

not sure what to do about this
image

@phansch
Copy link
Member

phansch commented Oct 4, 2019

@HMPerson1 It's a separate CI/Cargo issue unfortunately, not your fault. This should be merged later today.

phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 4, 2019
@phansch
Rollup merge of rust-lang#4614 - HMPerson1:abs_cast_unsigned, r=flip1995
19c58d2 
Allow casts from the result of `abs` to unsigned

changelog: Allow casts from the result of `abs` to unsigned in `cast_sign_loss`

Fixes rust-lang#4605
@phansch phansch mentioned this pull request Oct 4, 2019
Merged
bors added a commit that referenced this pull request Oct 4, 2019
@bors
Auto merge of #4625 - phansch:rollup-qp7ki0h, r=phansch
0ccf629 
Rollup of 2 pull requests

Successful merges:

 - #4509 (Fix false-positive of redundant_clone and move to clippy::perf)
 - #4614 (Allow casts from the result of `abs` to unsigned)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Oct 4, 2019
@bors
Auto merge of #4625 - phansch:rollup-qp7ki0h, r=phansch
249b6ca 
Rollup of 2 pull requests

Successful merges:

 - #4509 (Fix false-positive of redundant_clone and move to clippy::perf)
 - #4614 (Allow casts from the result of `abs` to unsigned)

Failed merges:

changelog: none

r? @ghost
@bors bors merged commit 0e1dd65 into rust-lang:master Oct 4, 2019
@flip1995 flip1995 mentioned this pull request Oct 27, 2019
Closed
@jhpratt
Copy link
Member

jhpratt commented Nov 8, 2019

@phansch What's the timeframe for this to land on stable? I just upgraded to rustc 1.39 and it doesn't look like this PR is part of the related clippy build.

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

Should be in beta now and therefore it will be in stable 1.40.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0i8.abs() as u8 is not lossy
5 participants
@HMPerson1 @flip1995 @bors @phansch @jhpratt