Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clippy plugin #4714

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Remove clippy plugin #4714

merged 1 commit into from
Nov 6, 2019

Conversation

msizanoen1
Copy link
Contributor

@msizanoen1 msizanoen1 commented Oct 22, 2019 •
edited by Manishearth
Loading

This PR removes the clippy plugin, which is already deprecated and is causing the fmt_macros not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface

@flip1995 flip1995 added S-needs-discussion Status: Needs further discussion before merging or work can be started S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 22, 2019
@flip1995
Copy link
Member

This won't remove the fmt_macros dependence? Also we didn't decide on how / when to remove the Clippy plugin interface. I think just nuking it is ok though, since the warning existed for a long time. cc #2783

ping @rust-lang/clippy thoughts on this?

@flip1995
Copy link
Member

Maybe this is better done in combination with #4650

@msizanoen1
Copy link
Contributor Author

msizanoen1 commented Oct 22, 2019 •
edited
Loading

The error happens because clippy_lints was compiled for the host but fmt_macros is only available for the target. Plugins are compiled for the host so removing the plugin should fix the error.
The error is about cross compilation.

@flip1995
Copy link
Member

Ah ok, thanks for the clarification!

@Manishearth
Copy link
Member

We should definitely just remove it, yeah

@tesuji tesuji mentioned this pull request Oct 22, 2019
Merged
phansch
phansch approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should write a short announcement about removing this on inside-rust? With clear migration instructions, etc..

Apart from that I think we should finally remove this.

@flip1995 flip1995 mentioned this pull request Oct 24, 2019
Merged
@flip1995
Copy link
Member

I opened rust-lang/blog.rust-lang.org#435 for this. Feedback welcome.

@msizanoen1 msizanoen1 mentioned this pull request Oct 24, 2019
Merged
@bors
Copy link
Collaborator

bors commented Oct 24, 2019

☔ The latest upstream changes (presumably #4650) made this pull request unmergeable. Please resolve the merge conflicts.

@evanjs evanjs mentioned this pull request Oct 31, 2019
Merged
@msizanoen1
Copy link
Contributor Author

Now with rust-lang/rust#65698 merged, this PR is the only remaining roadblock for rust-lang/rust#62558

@msizanoen1 msizanoen1 mentioned this pull request Nov 1, 2019
Closed
bors added a commit that referenced this pull request Nov 3, 2019
@bors
Auto merge of #4757 - evanjs:issue/4748, r=phansch
d3302c2 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)
bors added a commit that referenced this pull request Nov 3, 2019
@bors
Auto merge of #4757 - evanjs:issue/4748, r=phansch
04d8fca 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@Manishearth
Copy link
Member

@bors r+

https://blog.rust-lang.org/inside-rust/2019/11/04/Clippy-removes-plugin-interface.html

@bors
Copy link
Collaborator

bors commented Nov 4, 2019

📌 Commit a127e14 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Nov 4, 2019

⌛ Testing commit a127e14 with merge 13578b5...

bors added a commit that referenced this pull request Nov 4, 2019
@bors
Auto merge of #4714 - msizanoen1:remove-plugin, r=Manishearth
13578b5 
Remove clippy plugin

This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)
@bors
Copy link
Collaborator

bors commented Nov 4, 2019

💔 Test failed - checks-travis

@Manishearth
Copy link
Member

@bors r+ retry

@bors
Copy link
Collaborator

bors commented Nov 4, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Nov 4, 2019

📌 Commit a127e14 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Nov 4, 2019

⌛ Testing commit a127e14 with merge f14037b...

bors added a commit that referenced this pull request Nov 4, 2019
@bors
Auto merge of #4714 - msizanoen1:remove-plugin, r=Manishearth
f14037b 
Remove clippy plugin

This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface
@bors
Copy link
Collaborator

bors commented Nov 4, 2019

💔 Test failed - checks-travis

@Manishearth
Copy link
Member

#4770

@mati865 mati865 mentioned this pull request Nov 5, 2019
Closed
@tesuji
Copy link
Contributor

tesuji commented Nov 6, 2019

This can be merged.
@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented Nov 6, 2019

@lzutao: 🔑 Insufficient privileges: Not in reviewers

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Nov 6, 2019

📌 Commit a127e14 has been approved by Manishearth

bors added a commit that referenced this pull request Nov 6, 2019
@bors
Auto merge of #4714 - msizanoen1:remove-plugin, r=Manishearth
eae7b99 
Remove clippy plugin

This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface
@bors
Copy link
Collaborator

bors commented Nov 6, 2019

⌛ Testing commit a127e14 with merge eae7b99...

@bors
Copy link
Collaborator

bors commented Nov 6, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing eae7b99 to master...

@bors bors merged commit a127e14 into rust-lang:master Nov 6, 2019
@msizanoen1 msizanoen1 deleted the remove-plugin branch November 6, 2019 05:13
@msizanoen1 msizanoen1 mentioned this pull request Nov 6, 2019
Closed
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
@flip1995
Rollup merge of rust-lang#4757 - evanjs:issue/4748, r=phansch
53a99cd 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
@flip1995
Rollup merge of rust-lang#4757 - evanjs:issue/4748, r=phansch
2fed74e 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #4757 - evanjs:issue/4748, r=phansch
842cfb0 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@msizanoen1 msizanoen1 mentioned this pull request Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@phansch phansch phansch approved these changes

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@msizanoen1 @flip1995 @Manishearth @bors @tesuji @phansch