Add the TARGET_LIBS environment variable for rustc CI testing #4786
Conversation
|
Ping @flip1995 |
msizanoen1
force-pushed
the
target-libs
branch
2 times, most recently
from
12b46b9 to
ac4e589
Compare
msizanoen1
force-pushed
the
target-libs
branch
2 times, most recently
from
59b43e8 to
fa8d9db
Compare
|
build failed because of format check. Could you run |
msizanoen1
force-pushed
the
target-libs
branch
from
fa8d9db to
52f9927
Compare
|
Do you think this will work when cross compiling? I'm strongly inclined to just disable these tests when running rustc ci. |
|
Tools tests aren't ran when cross compiling right now. |
|
Oh, right! Anyway, I found a better fix for this in #4784, we really shouldn't be linking to clippy_lints in those tests anyway. |
|
Actually even with that PR you will still get the |
|
About the tools are tested only when building natively assumption, the rustbuild build system always pass the |
|
Cross testing is not a goal of this PR. |
msizanoen1
force-pushed
the
target-libs
branch
from
775b8e3 to
6e187ef
Compare
msizanoen1
force-pushed
the
target-libs
branch
from
6e187ef to
7d2e813
Compare
| @@ -27,6 +27,11 @@ fn host_libs() -> PathBuf { | |||
| } | |||
| } | |||
|
|
|||
| #[must_use] | |||
There was a problem hiding this comment.
the must_use isn't necessary
|
@Brors r+ will land for now and maybe make minor fixes later |
|
@bors r+ |
|
📌 Commit 7d2e813 has been approved by |
Add the TARGET_LIBS environment variable for rustc CI testing Needed to fix the test failure in rust-lang/rust#66158. See rust-lang/rust#66158 (comment) r? @Manishearth
|
💔 Test failed - checks-travis |
|
@bors retry Changelog was missing |
Add the TARGET_LIBS environment variable for rustc CI testing Needed to fix the test failure in rust-lang/rust#66158. See rust-lang/rust#66158 (comment) r? @Manishearth changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Needed to fix the test failure in rust-lang/rust#66158.
See rust-lang/rust#66158 (comment)
r? @Manishearth
changelog: none