no more must-use-candidate impls #4794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 |
|
I think we should keep linting impls and just bail out on trait impls |
phansch
added
the
S-waiting-on-author
llogiq
force-pushed
the
no-must-use-impls
branch
from
a9bf329 to
5f0f673
Compare
|
@flip1995 good point. I changed the code to reflect this. |
|
Thanks! @bors r+ |
|
📌 Commit 5f0f673 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 13, 2019
no more must-use-candidate impls This should help with #4779.
|
💔 Test failed - checks-travis |
|
@bors retry changelog was missing |
bors
added a commit
that referenced
this pull request
Nov 13, 2019
no more must-use-candidate impls This should help with #4779. changelog: don't trigger [`must_use_candidate`] on trait impls
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with #4779.
changelog: don't trigger [
must_use_candidate] on trait impls