Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustup rust-lang/rust#66188 #4795

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Rustup rust-lang/rust#66188 #4795

merged 2 commits into from
Nov 8, 2019

Conversation

HMPerson1
Copy link
Contributor

changelog: none

matthiaskrgr
matthiaskrgr approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@matthiaskrgr matthiaskrgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+
thanks!

@matthiaskrgr
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit 94b36d9 has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit 94b36d9 with merge d480273...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #4795 - HMPerson1:rustup, r=matthiaskrgr
d480273 
Rustup rust-lang/rust#66188

changelog: none
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2019
Closed
@bors
Copy link
Contributor

bors commented Nov 8, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

@bors retry p=10 (weird osx error)

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit 94b36d9 with merge 37fa1e2...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #4795 - HMPerson1:rustup, r=matthiaskrgr
37fa1e2 
Rustup rust-lang/rust#66188

changelog: none
@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

@bors treeclose=10

There are currently 3 more PRs in queue. (it's treeclose-, not treeclosed- to open up the queue again, BTW)

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

@bors treeclosed=10

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

But to actually close the tree you have to write treeclosed? 🤔

@matthiaskrgr
Copy link
Member

Hm, it should be treeclose according to the page https://buildbot2.rust-lang.org/homu/ 🤔

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

It actually is treeclosed for both. See source code: https://github.com/rust-lang/homu/blob/1e0041c8f6db6500dbc587cf581597092b130cea/homu/parse_issue_comment.py#L246

@flip1995 flip1995 mentioned this pull request Nov 8, 2019
Merged
@bors
Copy link
Contributor

bors commented Nov 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: matthiaskrgr
Pushing 37fa1e2 to master...

@bors bors merged commit 94b36d9 into rust-lang:master Nov 8, 2019
@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

@bors treeclosed-

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019

@bors are you still there?

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2019 •
edited
Loading

Is it possible, that bors doesn't fetches closed PRs and you have to open the tree in an open PR?

cc #4776 (comment)

@mati865
Copy link
Contributor

mati865 commented Nov 8, 2019

@flip1995 it's exactly the case.

@HMPerson1 HMPerson1 deleted the rustup branch November 9, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaskrgr matthiaskrgr matthiaskrgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HMPerson1 @matthiaskrgr @bors @flip1995 @mati865