Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lint generator import #5055

Merged

Conversation

krishna-veerareddy
Copy link
Contributor

@krishna-veerareddy krishna-veerareddy commented Jan 16, 2020

Fix rustc_lint import path and add lifetimes to LateLintPass in new_lint command.

changelog: none

@krishna-veerareddy
Copy link
Contributor Author

@bradsherman Hey I was testing out the new_lint command and found a few issues so fixing them here. Please review when you have some time.

@llogiq
Copy link
Contributor

llogiq commented Jan 16, 2020

LGTM, @bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2020

📌 Commit 9ebac16 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Jan 16, 2020

⌛ Testing commit 9ebac16 with merge 6bd0580...

bors added a commit that referenced this pull request Jan 16, 2020
…t, r=llogiq

Fix new lint generator import

Fix `rustc_lint` import path and add lifetimes to `LateLintPass` in `new_lint` command.

changelog: none
@bors
Copy link
Contributor

bors commented Jan 16, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: llogiq
Pushing 6bd0580 to master...

@bors bors merged commit 9ebac16 into rust-lang:master Jan 16, 2020
@bradsherman
Copy link
Contributor

sorry I missed this I was at work. Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants