Don't trigger [debug_assert_with_mut_call] on debug_assert!(_.await) #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
flip1995
force-pushed
the
dbg_assert_mut_async
branch
2 times, most recently
from
9979ab7 to
1cc62de
Compare
flip1995
force-pushed
the
dbg_assert_mut_async
branch
from
1cc62de to
7b302e9
Compare
flip1995
force-pushed
the
dbg_assert_mut_async
branch
from
7b302e9 to
5ba4aa8
Compare
|
@rust-lang/clippy We should merge this ASAP (at least the move to nursery) and probably backport it to beta. #5112 |
|
@bors r+ |
|
📌 Commit 5ba4aa8 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
|
Thanks! I'll do the backport tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5105
cc #5112
changelog: Don't trigger [
debug_assert_with_mut_call] ondebug_assert!(_.await)and move it to nursery.