Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option-env-unwrap lint #5148

Merged
merged 4 commits into from
Feb 10, 2020
Merged

Add option-env-unwrap lint #5148

merged 4 commits into from
Feb 10, 2020

Conversation

krishna-veerareddy
Copy link
Contributor

changelog: Add option-env-unwrap lint

Fixes #5147

tesuji
tesuji reviewed Feb 9, 2020
View reviewed changes
clippy_lints/src/option_env_unwrap.rs Outdated Show resolved Hide resolved
clippy_lints/src/option_env_unwrap.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Feb 9, 2020
flip1995
flip1995 reviewed Feb 9, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

clippy_lints/src/option_env_unwrap.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

flip1995 commented Feb 9, 2020

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 9, 2020

📌 Commit a3a1587 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 9, 2020

⌛ Testing commit a3a1587 with merge 785f494...

bors added a commit that referenced this pull request Feb 9, 2020
@bors
Auto merge of #5148 - krishna-veerareddy:issue-5147-option-env-unwrap…
785f494 
…, r=flip1995

Add `option-env-unwrap` lint

changelog: Add `option-env-unwrap` lint

Fixes #5147
@bors
Copy link
Contributor

bors commented Feb 9, 2020

💔 Test failed - status-appveyor

@krishna-veerareddy
Use PATH environment variable for testing
b48b221 
The tests were failing on windows because the `HOME` env variable
doesn't exist on it so using the `PATH` variable to test instead.
@krishna-veerareddy krishna-veerareddy force-pushed the issue-5147-option-env-unwrap branch from 7811ae0 to b48b221 Compare February 9, 2020 23:36
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 10, 2020

📌 Commit b48b221 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 10, 2020

⌛ Testing commit b48b221 with merge c066807...

bors added a commit that referenced this pull request Feb 10, 2020
@bors
Auto merge of #5148 - krishna-veerareddy:issue-5147-option-env-unwrap…
c066807 
…, r=flip1995

Add `option-env-unwrap` lint

changelog: Add `option-env-unwrap` lint

Fixes #5147
@bors
Copy link
Contributor

bors commented Feb 10, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing c066807 to master...

@bors bors merged commit b48b221 into rust-lang:master Feb 10, 2020
This was referenced Feb 10, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesuji tesuji tesuji left review comments

@flip1995 flip1995 flip1995 left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use env!() instead of option_env!().unwrap()
4 participants
@krishna-veerareddy @flip1995 @bors @tesuji