Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend redundant_clone to the case that cloned value is not consumed #5304

Merged
merged 4 commits into from
Mar 12, 2020

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Mar 12, 2020

Fixes #5303.


changelog: Extend redundant_clone to the case that cloned value is not consumed

sinkuu added 4 commits March 13, 2020 00:31
`let y = x.clone()` cannot be turned into `let y = x` without moving x,
regardless of whether `y` is consumed or not.
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Waiting on rustup

@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Mar 12, 2020
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 12, 2020

📌 Commit d9ad338 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 12, 2020

⌛ Testing commit d9ad338 with merge 8485d40...

@bors
Copy link
Contributor

bors commented Mar 12, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8485d40 to master...

@bors bors merged commit 8485d40 into rust-lang:master Mar 12, 2020
@sinkuu sinkuu deleted the redundant_clone_not_consumed branch March 13, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FN redundant_clone
3 participants