Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity_op: allow 1 << 0 #5602

Merged
merged 1 commit into from
May 16, 2020
Merged

identity_op: allow 1 << 0 #5602

merged 1 commit into from
May 16, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented May 15, 2020

I went for accepting 1 << 0 verbatim instead of something more general as it seems to be what everyone in the issue thread needed.

changelog: identity_op: allow 1 << 0 as it's a common pattern in bit manipulation code.

Fixes #3430

@phansch
Copy link
Member

phansch commented May 16, 2020

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented May 16, 2020

📌 Commit fc8ab09 has been approved by phansch

@bors
Copy link
Contributor

bors commented May 16, 2020

⌛ Testing commit fc8ab09 with merge 53a9805...

@bors
Copy link
Contributor

bors commented May 16, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 53a9805 to master...

@bors bors merged commit 53a9805 into rust-lang:master May 16, 2020
@ebroto ebroto deleted the issue_3430 branch May 16, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identity_op warns for bitflag constant
3 participants