Fix out of bounds access by checking length equality BEFORE accessing by index. #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @phansch (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Yeah, I agree that would be pretty difficult 😅 Since it only happened in rustc so far, let's just go ahead and @bors r+ |
|
📌 Commit 1b3bc16 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 12, 2020
Fix out of bounds access by checking length equality BEFORE accessing by index. Fixes #5780 changelog: fix out of bounds access in unnested_or_patterns lint. Edit: I did not bother reducing a testcase from `librustc_typeck` crate but I can confirm that with the change the crash no longer occurs.
|
💔 Test failed - checks-action_test |
|
@bors rollup=always |
|
@bors retry |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jul 13, 2020
Fix out of bounds access by checking length equality BEFORE accessing by index. Fixes rust-lang#5780 changelog: fix out of bounds access in unnested_or_patterns lint. Edit: I did not bother reducing a testcase from `librustc_typeck` crate but I can confirm that with the change the crash no longer occurs.
This was referenced Jul 13, 2020
bors
added a commit
that referenced
this pull request
Jul 13, 2020
Rollup of 5 pull requests Successful merges: - #5443 (Some accuracy lints for floating point operations) - #5752 (Move range_minus_one to pedantic) - #5756 (unnecessary_sort_by: avoid linting if key borrows) - #5784 (Fix out of bounds access by checking length equality BEFORE accessing by index.) - #5786 (fix phrase in new_lint issue template) Failed merges: r? @ghost changelog: rollup
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5780
changelog: fix out of bounds access in unnested_or_patterns lint.
Edit: I did not bother reducing a testcase from
librustc_typeckcrate but I can confirm that with the change the crash no longer occurs.