improve advice in iter_nth_zero #5793
Conversation
The "use .next()" replacement advice is on the last line of the code snippet, where it is vulnerable to truncation. Display that advice at the beginning instead. closes rust-lang#5783
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @phansch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
clippy_lints/src/methods/mod.rs
Outdated
| "called `.nth(0)` on a `std::iter::Iterator`", | ||
| "try calling", | ||
| "called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent", | ||
| "try calling .next() instead of .nth(0)", |
There was a problem hiding this comment.
NIT:
| "try calling .next() instead of .nth(0)", | |
| "try calling `.next()` instead of `.nth(0)`", |
(remember to also update the stderr files after this change)
|
r? @flip1995 |
flip1995
added
S-waiting-on-author
|
Thanks! @bors r+ |
|
📌 Commit e83b3eb has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #5783
Please keep the line below
changelog: For iter_nth_zero, the "use .next()" replacement advice is on the last line of the code snippet, where it is vulnerable to truncation. Display that advice at the beginning instead.