Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic multiple args #5811

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Panic multiple args #5811

merged 2 commits into from
Jul 17, 2020

Conversation

JarredAllen
Copy link
Contributor

changelog: Fixes bug with panic lint reported in #5767. I also did the same changes to the lints for todo, unimplemented and unreachable, so those lints should now also detect calls to those macros with a message.

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 17, 2020
@phansch
Copy link
Member

phansch commented Jul 17, 2020

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 17, 2020

📌 Commit 07867fd has been approved by phansch

@bors
Copy link
Contributor

bors commented Jul 17, 2020

⌛ Testing commit 07867fd with merge 57678c8...

@bors
Copy link
Contributor

bors commented Jul 17, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 57678c8 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants