Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derive_ord_xor_partial_ord lint #5848

Merged
merged 12 commits into from
Aug 4, 2020
Merged

Add derive_ord_xor_partial_ord lint #5848

merged 12 commits into from
Aug 4, 2020

Commits on Jul 27, 2020

  1. run cargo dev new_lint 

    specifically:
cargo dev new_lint --name derive_ord_xor_partial_ord --category correctness --pass late
    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    5a64496 View commit details
    Browse the repository at this point in the history

  2. move derive_ord_xor_partial_ord into derive mod so we can reuse deriv… 

    …e_hash_xor_partial_eq code later
    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    fc20ee6 View commit details
    Browse the repository at this point in the history

  3. add test for derive_ord_xor_partial_ord based on test for derive_hash… 

    …_xor_partial_eq
    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    0722991 View commit details
    Browse the repository at this point in the history

  4. initial implementation based on code for derive_hash_xor_partial_eq… 

    … which is showing one error when there should be four
    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    068acbd View commit details
    Browse the repository at this point in the history

  5. use get_trait_def_id to check for Ord trait

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    a8d6eda View commit details
    Browse the repository at this point in the history

  6. update reference since we see the expected four errors

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    6c3e459 View commit details
    Browse the repository at this point in the history

  7. remove is_local check since getting the def_id directly makes it unne… 

    …cessary
    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    7dc9748 View commit details
    Browse the repository at this point in the history

  8. add description for derive_ord_xor_partial_ord

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    431924c View commit details
    Browse the repository at this point in the history

  9. run cargo dev fmt and fix overly long line

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    668b747 View commit details
    Browse the repository at this point in the history

  10. s/pord/partial_ord/ to fix dogfood failure

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    ca03f2b View commit details
    Browse the repository at this point in the history

  11. fill in lint description for DERIVE_ORD_XOR_PARTIAL_ORD

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    12a6eee View commit details
    Browse the repository at this point in the history

  12. run cargo dev update_lints

    @Ryan1729
    Ryan1729 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    94b10a6 View commit details
    Browse the repository at this point in the history